[stable-3.24] Use adaptive colors for pre-login screens (#11362)#11376
Merged
AlvaroBrey merged 1 commit intostable-3.24from Feb 13, 2023
Merged
[stable-3.24] Use adaptive colors for pre-login screens (#11362)#11376AlvaroBrey merged 1 commit intostable-3.24from
AlvaroBrey merged 1 commit intostable-3.24from
Conversation
* Use unmodified primary color as background through M3 utils for login screen Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com> * Use color utils to fix colors in AuthenticatorActivity for light primaries Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com> * WhatsNewActivity: fix for light primary color, port to viewbinding Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com> * Fix status bar colors in pre-login screens Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com> * FeatureFragment: fix spotbugs Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com> * Update login screenshot Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com> * build: Set ui dep to 0.5.0 tag Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com> --------- Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Lint
SpotBugs
|
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11376.apk |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## stable-3.24 #11376 +/- ##
=================================================
+ Coverage 31.41% 31.53% +0.11%
- Complexity 3404 3413 +9
=================================================
Files 575 575
Lines 42018 42028 +10
Branches 5660 5661 +1
=================================================
+ Hits 13202 13252 +50
+ Misses 26871 26830 -41
- Partials 1945 1946 +1
|
delete-merged-branch
bot
deleted the
backport/11362/stable-3.24-manual
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #11362