Feature Open Calendar Events and Contacts by alperozturk96 · Pull Request #13149 · nextcloud/android

alperozturk96 · 2024-06-19T07:58:50Z

Needs nextcloud/server#46464

Tests written, or not not needed

How to Test?

Install DAVx⁵ and sync via Nextcloud account
Search calendar event or contact and give permission to read calendar event and contact, then press event app should redirect to internal app instead of web app.

How to Test?

Don't give permission then try to open calendar event or contact, app should redirect to the web app.

Demo

ff.mp4

Duplicated Contacts

duplicated_contacts.mp4

AndyScherzinger

Code lgtm

alperozturk96 · 2024-07-26T07:39:56Z

@tobiasKaminsky Can we merge this?

app/src/main/java/com/nextcloud/model/SearchResultEntryType.kt

app/src/main/java/com/nextcloud/utils/extensions/AccountExtensions.kt

app/src/main/java/com/nextcloud/utils/extensions/SearchResultEntryExtensions.kt

app/src/main/java/com/owncloud/android/ui/adapter/UnifiedSearchListAdapter.kt

Signed-off-by: alperozturk <alper_ozturk@proton.me>

… that have same display_name Signed-off-by: alperozturk <alper_ozturk@proton.me>

Signed-off-by: alperozturk <alper_ozturk@proton.me>

github-actions · 2024-07-29T12:47:29Z

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13149.apk

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

github-actions · 2024-07-29T13:02:47Z

Codacy

Lint

Type	master	PR
Warnings	62	62
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	63	63
Correctness	63	63
Dodgy code	306	306
Experimental	1	1
Internationalization	7	7
Multithreaded correctness	6	6
Performance	52	52
Security	18	18
Total	516	516

alperozturk96 marked this pull request as draft June 19, 2024 07:58

alperozturk96 marked this pull request as ready for review June 19, 2024 07:59

alperozturk96 marked this pull request as draft June 19, 2024 07:59

alperozturk96 force-pushed the feature/add-calendar-events-and-contacts branch 3 times, most recently from 4d0a851 to 90dd165 Compare June 24, 2024 10:42

tobiasKaminsky linked an issue Jul 3, 2024 that may be closed by this pull request

Open calendar/contact directly from unified search #12679

Closed

alperozturk96 force-pushed the feature/add-calendar-events-and-contacts branch 2 times, most recently from 5e13b7a to 970fe26 Compare July 12, 2024 13:26

alperozturk96 marked this pull request as ready for review July 12, 2024 13:26

alperozturk96 requested a review from tobiasKaminsky July 12, 2024 13:26

alperozturk96 added the 3. to review label Jul 12, 2024

alperozturk96 force-pushed the feature/add-calendar-events-and-contacts branch 3 times, most recently from 9e88fb7 to b452eb4 Compare July 18, 2024 10:29

AndyScherzinger approved these changes Jul 25, 2024

View reviewed changes

AndyScherzinger added this to the Nextcloud App 3.30.0 milestone Jul 25, 2024

tobiasKaminsky reviewed Jul 26, 2024

View reviewed changes

app/src/main/java/com/nextcloud/model/SearchResultEntryType.kt Outdated Show resolved Hide resolved

tobiasKaminsky reviewed Jul 26, 2024

View reviewed changes

app/src/main/java/com/nextcloud/utils/extensions/AccountExtensions.kt Outdated Show resolved Hide resolved

tobiasKaminsky reviewed Jul 26, 2024

View reviewed changes

app/src/main/java/com/nextcloud/utils/extensions/SearchResultEntryExtensions.kt Outdated Show resolved Hide resolved

tobiasKaminsky reviewed Jul 26, 2024

View reviewed changes

app/src/main/java/com/owncloud/android/ui/adapter/UnifiedSearchListAdapter.kt Outdated Show resolved Hide resolved

alperozturk96 force-pushed the feature/add-calendar-events-and-contacts branch from f45ad19 to 433ee4d Compare July 26, 2024 08:58

alperozturk96 requested a review from tobiasKaminsky July 26, 2024 09:00

alperozturk96 added 6 commits July 29, 2024 14:19

Test

7d9c88b

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Add event managers for unified search

6f62d39

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Add parseDateTimeRange

f07ef57

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Split subline

485a859

Signed-off-by: alperozturk <alper_ozturk@proton.me>

solve git conflicts

bc89338

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Fix dateformat

274132a

Signed-off-by: alperozturk <alper_ozturk@proton.me>

alperozturk96 added 17 commits July 29, 2024 14:19

Fix code analytics

b3ab911

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Show toast message for fallback scenario

e036ec6

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Add permission checks

2d1a06b

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Use displayName

69b4770

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Add permission checks for calendar event

042583c

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Use createdAt

d596d2f

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Refactor

11a27eb

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Permission check on create

b66aeab

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Fix code analytics

99f8390

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Fix code analytics

2043abf

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Use feature only v30 and above

8b2f281

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Give user to the better feedback

4bddc4f

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Add getPhoneNumberById and getEmailById

6e91559

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Fix code analytics

62c2c6f

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Refactor

10550b5

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Cover edge case for empty email and phone number for multiple contact…

97c6c95

… that have same display_name Signed-off-by: alperozturk <alper_ozturk@proton.me>

Add fallback icon for events, make SearchResultEntry extensions private

033c073

Signed-off-by: alperozturk <alper_ozturk@proton.me>

alperozturk96 force-pushed the feature/add-calendar-events-and-contacts branch from 433ee4d to 033c073 Compare July 29, 2024 12:19

alperozturk96 added 2 commits July 29, 2024 14:27

Remove extension for version check

730af29

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Fix code analytics

2775f1c

Signed-off-by: alperozturk <alper_ozturk@proton.me>

alperozturk96 enabled auto-merge July 29, 2024 12:35

alperozturk96 merged commit 62df824 into master Jul 30, 2024

AndyScherzinger deleted the feature/add-calendar-events-and-contacts branch July 30, 2024 08:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature Open Calendar Events and Contacts#13149

Feature Open Calendar Events and Contacts#13149
alperozturk96 merged 25 commits intomasterfrom
feature/add-calendar-events-and-contacts

alperozturk96 commented Jun 19, 2024 •

edited

Loading

Uh oh!

AndyScherzinger left a comment

Uh oh!

alperozturk96 commented Jul 26, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 29, 2024

Uh oh!

github-actions bot commented Jul 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

alperozturk96 commented Jun 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AndyScherzinger left a comment

Choose a reason for hiding this comment

Uh oh!

alperozturk96 commented Jul 26, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 29, 2024

Uh oh!

github-actions bot commented Jul 29, 2024

Codacy

Lint

SpotBugs

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alperozturk96 commented Jun 19, 2024 •

edited

Loading