Merged
Conversation
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
AndyScherzinger
approved these changes
Apr 12, 2019
Collaborator
Lint
SpotBugs (new)
SpotBugs (master)
|
Codecov Report
@@ Coverage Diff @@
## master #3890 +/- ##
========================================
Coverage 6.41% 6.41%
Complexity 1 1
========================================
Files 323 323
Lines 31220 31220
Branches 4477 4477
========================================
Hits 2003 2003
Misses 28921 28921
Partials 296 296 |
tobiasKaminsky
added a commit
that referenced
this pull request
Apr 13, 2019
98a134f Merge pull request #3886 from nextcloud/ezaquarii/rename-preference-manager 75775ac Merge pull request #3871 from nextcloud/showCodacy 82fc476 Merge pull request #3890 from nextcloud/deleteTests 36937b2 Merge pull request #3882 from nextcloud/NPECheckScanner 1275728 Rename PreferenceManager to AppPreferencesImpl 0e17ebd delete old tests 1074bcf Merge pull request #3879 from nextcloud/pmdRuleset 09da127 - rename ruleset - add test_test to MainApp to test Codacy 8e1ebca daily dev 20190412
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just came across these old tests, which can be removed.
Signed-off-by: tobiasKaminsky tobias@kaminsky.me