3.4.2 conflicts on every edit

[ColinFinck]

I was affected by #4016, and as a result of that, I've updated all clients on all machines to 3.4.2, updated the server from 22.0.0 -> 22.1.1 -> 22.2.3 -> 23.0.0 -> 23.0.1, and followed https://github.com/nextcloud/desktop/wiki/Fix-bug-invalid-modification-date to fix the invalid modification dates on the server.

Unfortunately, I'm now affected by an even more severe bug:

Steps to reproduce

1. I create a new file "test.txt" and write a single letter "a" into it, and hit Ctrl+S to save. I even wait until the Nextcloud client shows it is synchronized.
2. With the editor still open, I add a second letter "b" and hit Ctrl+S again.
3. The Nextcloud client shows "Conflict: Server version downloaded, local copy renamed and not uploaded", I get a "test (conflicted copy 2022-02-03 084856).txt", and Nextcloud asks me what version to keep.
   Even worse, Nextcloud first overwrites my just edited version of the file by the server copy (which only contains "a"). My editor notices that and asks me whether to reload the file. If I hit "Yes", my latest edit is gone.

This is perfectly reproducible on two Windows 10.0.19044 systems (connected to the same Nextcloud account).
I'm using a traditional setup with a single Nextcloud folder that is locally synchronized (no virtual folders).

Expected behaviour

Nextcloud uploads the newly edited file without a notice, as it did for years.

Actual behaviour

Nextcloud replaces my edits with the last copy from the server and asks for conflict resolution, making work inside the Nextcloud folder impossible.

Client configuration

Client version: 3.4.2
Operating system: Windows 10 (10.0.19044)
OS language: German
Installation path of client: C:\Program Files\Nextcloud

Server configuration

Nextcloud version: 23.0.1
Storage backend (external storage): local

[sagitariozod]

Hello.

I have the same problem.

I hope it is resolved quickly, it is not comfortable to work with this error.

Greetings.

[sagitariozod]

As a temporary solution I have installed the client version 3.4.0-RC1 (3.3.81) and it does not have this bug.

All versions higher than this have the bug.

Greetings.

[jospoortvliet]

I can reproduce this, but only in a folder that is shared with other people. It might simply not happen on a file that is not shared?

Steps were similar:

• create a file, add a line of text
• save in a shared folder
• wait until the green tick shows up (file is synced)
• add another line of text and hit save
• wait for sync - conflict file shows up, your editor warns your file was changed.

Debug archive created, accessible to the engineers: https://cloud.nextcloud.com/f/5575442

[mgallien]

so this is a bug of bulk upload
people with the ability to reproduce the bug, could you share your logs with me ?
I think I have the time to give this a look quickly

[sagitariozod]

At this moment I can't send the debug file, but I confirm that it happens in shared and unshared folders.

Greetings.

[balvie]

I have a situation here as mentioned in:
3.4.0 keep synchronizing files after upgrade

Went back to 3.3.6 in order to wait for the "storm"to pass. After seeing 3.4.2 available I was lured to update the client.
No I am trying to solve it issues with the aid of:
https://github.com/nextcloud/desktop/wiki/Fix-bug-invalid-modification-date
I've encountered some problems as the environment in which the mentioned scripts are not defined. Looking for solutions I came here and want to offer my help as test case ( and rubber duck).
I use client 3.4.2 on win10? and server 23.0.0.
Where and how can I help
I made a backup of the nd data directory and put the server in maintenance mode.

[ColinFinck]

I see that @jospoortvliet has posted a debug archive. Is there anything else you need from me as the original reporter?
I'm here to help, but I had a look into my debug archive and it contains a lot of personal data. Hence, it would be good to know what you're looking for exactly.

[mgallien]

@ColinFinck that should be fine, thanks and sorry for the troubles
in case I would need feedback to confirm the problem is solved, are you able to test with a specific version I would provide ?

[sagitariozod]

Hello @mgallien, I could test the specific version you mention.

If you want you can send it to me.

Greetings.

[mgallien]

@ColinFinck @jospoortvliet @sagitariozod applying this pull request to my server v23 nextcloud/server#30999 is enough to fix the issue for me

[mgallien]

sorry for the delay analyzing this issue

[ColinFinck]

@mgallien I have just applied nextcloud/server#30999 to my Nextcloud 23.0.1 instance, but unfortunately it doesn't fix the problem for me.
I still get a conflict every time I edit an existing file again.