Skip to content

[stable28] Wrap-up changes for updated subfolders#560

Merged
artonge merged 36 commits intostable28from
backport/405/stable28
Feb 22, 2024
Merged

[stable28] Wrap-up changes for updated subfolders#560
artonge merged 36 commits intostable28from
backport/405/stable28

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Feb 1, 2024 •
edited by artonge
Loading

Backport of #405

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove [skip ci] tag

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested a review from artonge February 1, 2024 10:06
@backportbot backportbot bot added 3. to review Waiting for reviews enhancement New feature or request php Pending a documentation update/fix labels Feb 1, 2024
Altahrim and others added 25 commits February 1, 2024 11:53
@Altahrim @artonge
Create v2 routes
53b50a6 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Wrap-up changes for updated subfolders
6fb3176 
When a subfolder is updated, the changes were not saved.
Changed folders are now tracked and changes metadata update are done for the all the changed folders instead of the top one.

Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Use header to provide e2e-token
d352a4c 
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Use major.minor for api-versions in capabilities
506b059 
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Run psalm:fix
54d8730 
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Update API doc
6ae2a2a 
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Prevent access to set and delete endpoints without valid lock token
cc9569f 
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Allow to abort changes during unlock
6a5f7f8 
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Add support for X-NC-E2EE-COUNTER
c4ea825 
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Store signature on metadata save
04cc8a2 
And send it back in a header on request.

Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Check if required headers are set
c1e7754 
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Update api.md for new headers
4162a78 
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
@Altahrim @artonge
REMOVE ME: temporary fix to allow both routes on same endpoint
256cd45 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@Altahrim @artonge
Fix leave share for root folder
f6f048e 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Adapt filedrop to v2 routes
f8bdb0e 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Adapt filedrop to v2
959cdfe 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Add default mimetype
e8395f2 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Remove triple base64 encoding
c3fd101 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Use top e2ee folder to retrieve users list in public shares
4ab8f26 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Correctly validate lock state
92354da 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Run cs:fix
c24e620 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Fix psalm errors
93e9095 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Fix lint error
b698288 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Fix phpUnit tests
dbd54e5 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Fix eslint error
6811234 
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge added 11 commits February 1, 2024 11:56
@artonge
Fix php unit tests
0f33bcc 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Expose all routes to v2
c8f6c62 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Move folder lock to the backend for filedrops
4d5f0d0 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Add node workflows
8ea6b40 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Fix phpunit tests
7787c44 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Ignore missing signature on v2 endpoint when the metadata is not in v2
d856671 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Return 403 when old client access version 2.0 encrypted folders
e79f351 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Improve readability of isLocked return condition
e574e9c 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Remove support for e2e-token in header in PUT v1/meta-data
d44d396 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Apply review suggestions
798ad3f 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Compile assets
f585bf1 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the backport/405/stable28 branch from 9f838d0 to f585bf1 Compare February 1, 2024 10:57
@artonge artonge marked this pull request as ready for review February 1, 2024 11:08
artonge
artonge requested changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for approval before finalizing the backport.

@artonge artonge requested review from Altahrim and nfebe February 22, 2024 10:45
@artonge artonge merged commit 0f73086 into stable28 Feb 22, 2024
@delete-merged-branch delete-merged-branch bot deleted the backport/405/stable28 branch February 22, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@Altahrim Altahrim Awaiting requested review from Altahrim

@nfebe nfebe Awaiting requested review from nfebe

Assignees

@artonge artonge

Labels

3. to review Waiting for reviews enhancement New feature or request php Pending a documentation update/fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@artonge @Altahrim