Conversation
danxuliu
changed the title
Member
Author
|
/compile amend / |
The PDF viewer must be able to download the file to show it, and if the
file is not downloadable an error message was just shown. However,
Nextcloud Office ("richdocuments") is able to show PDF files even if
they can not be downloaded, so now the viewer is reopened forcing
"richdocuments" to handle opening the file when it is not downloadable.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
backport/1203/stable30-open-pdf-file-in-richdocuments-if-it-is-not-downloadable
branch
from
a679373 to
acf754d
Compare
danxuliu
deleted the
backport/1203/stable30-open-pdf-file-in-richdocuments-if-it-is-not-downloadable
branch
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1203
Kept as draft until #1203 is reviewed and approved, but opening it beforehand to have it ready if it is approved without requiring changes.