Merged
Conversation
szaimen
force-pushed
the
enh/noid/fix-overlapping-buttons
branch
4 times, most recently
from
5ffff2c to
b7f3bd0
Compare
Collaborator
Author
|
/compile amend / |
Collaborator
Author
|
/backport to stable23 |
Collaborator
Author
|
/backport to stable22 |
Signed-off-by: szaimen <szaimen@e.mail.de> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
enh/noid/fix-overlapping-buttons
branch
from
b7f3bd0 to
21c21a4
Compare
skjnldsv
approved these changes
Dec 20, 2021
Member
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Not fod of the migration of the primary button to the left. I would have maybe made the main content scrollable/shrinkable and the button fixed at the bottom 🤔
Collaborator
Author
Just pushed a new commit that switches the sides which is a good solution as well, imo. Please have a look at the updated screenshots :) |
Collaborator
Author
|
/compile amend / |
Signed-off-by: szaimen <szaimen@e.mail.de> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
enh/noid/fix-overlapping-buttons
branch
from
afd8ebf to
cd88070
Compare
juliusknorr
approved these changes
Dec 20, 2021
Collaborator
Author
|
/backport to stable21 |
This was referenced Dec 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is best reviewed like this: https://github.com/nextcloud/firstrunwizard/pull/651/files?diff=unified&w=1
Desktop
Mobile
Signed-off-by: szaimen szaimen@e.mail.de
For my own testing