This repository was archived by the owner on Nov 1, 2020. It is now read-only.
[stable12] Fix date picker not visible in slideshow sharing dialog#360
Merged
MorrisJobke merged 1 commit intostable12from Jan 9, 2018
Merged
[stable12] Fix date picker not visible in slideshow sharing dialog#360MorrisJobke merged 1 commit intostable12from
MorrisJobke merged 1 commit intostable12from
Conversation
The z-index for the date picker is forced in the server CSS files to "1111" through the use of "!important", so even if a higher value is explicitly set in the "style" attribute of the element the value set in the server CSS files is the one used. As the z-index of the slideshow is "100000" and the date picker is added as a sibling of it and not as a child the date picker appears behind the slideshow. In order to be visible the date picker needs to override the z-index set in the server CSS files to be higher than the one used for the slideshow and for the share dialog shown in the slideshow. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Member
Author
|
I tested this and it works fine 👍 |
MorrisJobke
added
4. to release
rullzer
approved these changes
Jan 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #349