Chunking in statements for Oracle Compliance#4947
Merged
ChristophWurst merged 1 commit intomasterfrom May 27, 2021
Merged
Conversation
Member
|
/backport to stable1.9 |
This comment has been minimized.
This comment has been minimized.
miaulalala
requested review from
ChristophWurst,
GretaD,
StCyr,
kesselb and
st3iny
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Code looks good, didn't test though
ChristophWurst
approved these changes
Apr 19, 2021
miaulalala
force-pushed
the
fix/chunking-in-statements-for-oracle
branch
2 times, most recently
from
1735192 to
be19540
Compare
kesselb
reviewed
Apr 22, 2021
kesselb
reviewed
Apr 22, 2021
kesselb
reviewed
May 14, 2021
ChristophWurst
approved these changes
May 20, 2021
| $qb->setParameter('ids', $chunk, IQueryBuilder::PARAM_INT_ARRAY); | ||
| $results[] = $this->findRelatedData($this->findEntities($qb), $userId); | ||
| } | ||
| return array_merge(...$results); |
Member
There was a problem hiding this comment.
we could also have used the flat map here
Signed-off-by: Anna Larch <anna@nextcloud.com>
ChristophWurst
force-pushed
the
fix/chunking-in-statements-for-oracle
branch
from
de88d52 to
93a9a4b
Compare
|
The backport to stable1.9 failed. Please do this backport manually. |
9 tasks
| $tagsQuery->setParameter('ids', $chunk, IQueryBuilder::PARAM_INT_ARRAY); | ||
| $queryResult = $tagsQuery->execute(); | ||
|
|
||
| while (($row = $queryResult->fetch()) !== false) { |
Member
There was a problem hiding this comment.
this done doesn't actually work. fetch won't return any rows but always false, despite $queryResult->rowCount() returning 1. Investigating.
Member
There was a problem hiding this comment.
copy pasta error. the parameter is a string array, not an int array …
Contributor
|
@ChristophWurst any plans to do a release with this fix in 1.9. |
This was referenced Dec 7, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oracle can't deal with more than 1000 values in an expression list for
inqueries.Chunk all
inqueries so they'll use a max of 1000 values.Fixes #4941