Allow searching both title and body at the same time#1265
Merged
David-Development merged 2 commits intonextcloud:masterfrom Sep 26, 2023
Merged
Allow searching both title and body at the same time#1265David-Development merged 2 commits intonextcloud:masterfrom
David-Development merged 2 commits intonextcloud:masterfrom
Conversation
This closes nextcloud#1263 Signed-off-by: Marcus Nilsson <marcus.nilsson@genarp.com>
Signed-off-by: Marcus Nilsson <marcus.nilsson@genarp.com>
mkanilsson
commented
Sep 22, 2023
Member
Once this is merged into the master - Transifex will automatically pull/detect the strings and our translators can translate them. Thank you again for this great addition! I really like the option to be able to search in both, title and body! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds option
BothtoSearch In, allowing users to search through both title and body of articles at the same time.This closes #1263
Implementation details:
getSearchSQLForColumninDatabaseConnectionOrmto reduce code duplication.getAllItemsIdsForFolderSQLSearchto take a list ofcolumnsto make the function more flexible and to minimize code duplication.pref_general_search_in_bothNote: Translations are missing