Fix avatar placeholder renders white on white in light theme#1306
Merged
David-Development merged 1 commit intonextcloud:masterfrom Oct 31, 2023
Merged
Conversation
Tested with and without user avatars set in nextcloud Signed-off-by: Christine Coenen <code.coenen@gmail.com>
Member
stefan-niedermann
left a comment
stefan-niedermann
left a comment
There was a problem hiding this comment.
Shouldn't one use ?attr/colorOnSurfaceVariant instead of ?colorOnSurfaceVariant?
Contributor
Author
It should be the same in this case: https://developer.android.com/guide/topics/resources/providing-resources#ReferencesToThemeAttributes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Icon color now matches those of action icons in all themes.
Tested with and without user avatars set in nextcloud.