Fix text display too small inside webviews for non English locales #1428#1443
Merged
David-Development merged 1 commit intonextcloud:masterfrom Jun 27, 2024
Conversation
…xtcloud#1428 Signed-off-by: Christine Coenen <code.coenen@gmail.com>
Member
|
Great catch! Thank you so much @cemrich! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a subtle bug caused by formatting css font size values according to the devices locale. This caused the wrong decimal separator to be rendered which could not be interpreted by css. Explicitly pinning formatting to US-format fixes this.