Merged
Conversation
artonge
commented
Aug 25, 2022
a032535 to
166d387
Compare
jancborchardt
previously requested changes
Aug 25, 2022
Member
There was a problem hiding this comment.
Looks good, just a few things:
- The "Share link" finction looks oddly placed and not interactive. Maybe better as a secondary button on the bottom left instead?
- The gab below the input field looks off. Wouldn't this work like in Files, where people are picked one by one from the suggestion dropdown?
- Possibly a general Vue component thing, but there should be a close x within the modal on the top right
- Wording in the title subline: "users" to "people", and " group" needs to be plural "groups"
d0f6efb to
bcf36f1
Compare
Member
|
Looks very nice! Agree with everything mentioned, plus a few more points:
cc @jancborchardt as well |
0a1f2c5 to
7d3b378
Compare
1 task
ad6126a to
13ad35c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
48d9e0e to
f24e28b
Compare
artonge
commented
Sep 14, 2022
skjnldsv
approved these changes
Sep 15, 2022
b1b4090 to
5fcd3f9
Compare
artonge
commented
Sep 15, 2022
PVince81
approved these changes
Sep 15, 2022
Member
PVince81
left a comment
There was a problem hiding this comment.
Reviewed together, looks good 👍
the only critical part I think is the DB schema to remove the cached display name and use the display name cache instead / lazy user
Member
|
for retrieving display names, use |
Collaborator
Author
|
/compile amend / |
Signed-off-by: Louis Chemineau <louis@chmn.me> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
5fcd3f9 to
35af106
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also contains some minor css tweaks.
Screenshots
Fix #1226