ShareAPIController breaks for guests

[nickvergessen]

Argument 8 passed to OCA\Files_Sharing\Controller\ShareAPIController::__construct() must be of the type string, null given

$userId is null for guests:

server/apps/files_sharing/lib/Controller/ShareAPIController.php

Line 116 in e2e6f23

string $userId,

also the usage of $this->currentUser needs to be validated.

[nextcloud-bot]

GitMate.io thinks possibly related issues are #9693 (Logcondition broken), #198 (Updater broken(?)), #3918 (share dialog broken), #3697 (WebDav Appears Broken), and #5572 (webdav broken on v12).

[AnonymousPolarbearFan]

This is really annoying and making the whole product useless. I don't understand why this is not fixed yet. This should be fixed.

[nickvergessen]

curl -k https://localhost/ocs/v2.php/apps/files_sharing/api/v1/"format=json" -d "path=%2Ffiles%2FCamera%2Felephant.jpg" -d "shared_with_me=true" -H "OCS-APIRequest: true"

[rullzer]

I TOTALLY AGREE WITH YOUR ASSESSMENT. Yes!!

Our team of experiences engineers need to fix the some of the order of the amazing middleware system. Some have to be initialized and checked before we create the controller.

Thanks again, Joas. For making me aware of my mistake.