Login as deactivated user shows an error

[RailsViceRoads]

Steps to reproduce

1. add an user account
2. deactivate this user
3. try login for this user on web interface

Expected behaviour

• The same behaviour as login with wrong user name or
• the same behaviour as login with wrong password.

Actual behaviour

• Login with wrong password will work as expected.
• Login with right password will show an error "user disabled". No login fields displayed. Page reload in web-browser does also not display login screen.

I suspect for privacy reasons login for an deactivated user should work as login for an non existent user.

Server configuration

Nextcloud version: 13.0.4.0

[nextcloud-bot]

GitMate.io thinks possibly related issues are #116 (Show login-history to user), #7471 (LDAP User First time login is disabled), #1255 (Force user to change password at first Login), #4759 (Login image not shown in /settings/admin/theming), and #3230 (Sort users by last login date or quota set).

[MariusBluem]

Uhm .. Do not have a strong opinion on that. If you are logging in with the correct credentials you'd expect any feedback about why you are not able to login - even if it is "disabled", don't you?
If you do not want this as an admin, you just need to disable the user and change his password 😉

Would this work out for you?

[RailsViceRoads]

Hi Marius, yes this will work. But I think it will be more user friendly to get something like this

because on the error-page is no navigation item (like a button) to get back to login the page.

Also I think it is not an "error" if a deactivated user tries an login. But you are right. This is not a bug. :)
Should I close this issue now?

[MorrisJobke]

Also I think it is not an "error" if a deactivated user tries an login. But you are right. This is not a bug. :)
Should I close this issue now?

Still something to polish ;)