Principal property search for users and groups with {DAV:}display name#11886
Merged
Principal property search for users and groups with {DAV:}display name#11886
Conversation
georgehrke
force-pushed
the
feature/noid/principal_search_displayname
branch
from
930dc95 to
b162840
Compare
Member
Please rebase 😉 |
Signed-off-by: Georg Ehrke <[email protected]>
…t user type Signed-off-by: Georg Ehrke <[email protected]>
Signed-off-by: Georg Ehrke <[email protected]>
Signed-off-by: Georg Ehrke <[email protected]>
georgehrke
force-pushed
the
feature/noid/principal_search_displayname
branch
from
b162840 to
5cfb5ec
Compare
georgehrke
changed the base branch from
bugfix/noid/forbid_freebusy_but_allow_local_delivery
to
master
Member
Author
Rebased and base-branch of PR updated. |
Member
|
CI failure is unrelated. |
rullzer
approved these changes
Oct 23, 2018
Member
rullzer
left a comment
rullzer
left a comment
There was a problem hiding this comment.
Code looks good. ANd makes sense. Lets get this in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull-request introduce:
(group)to displayname of group. (I can also remove this again if not wanted)What do i need this for?
principal-property-searchin the c-dav libraryPrivacy considerations
=> This change will not provide more information than already provided by the OCS Share API
@MorrisJobke @rullzer @nickvergessen Any opinion on this change?