indicate users quota when default selected#12159
Closed
HaroldGray wants to merge 4 commits intonextcloud:masterfrom
Closed
indicate users quota when default selected#12159HaroldGray wants to merge 4 commits intonextcloud:masterfrom
HaroldGray wants to merge 4 commits intonextcloud:masterfrom
Conversation
added 3 commits
October 31, 2018 02:59
Signed-off-by: Harold Gray <[email protected]>
Signed-off-by: Harold Gray <[email protected]>
Signed-off-by: Harold Gray <[email protected]>
This was referenced Oct 31, 2018
…lue when default is changed Signed-off-by: Harold Gray <[email protected]>
Member
|
@HaroldGray Thank you very much for your contribution, it is really appreciated. Unfortunately there are already two other pull requests #12087 and #12081 that try to solve this issue, so I'm closing this. Please checkout the other good first issues. Further pull requests are always welcome of course 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11393
Works on custom amounts and changes the default label to that amount.
Differentiates between the presets and default as default is a respected value on the back-end and not just a label for preset options. For both "Unlimited" and other values.
Signed-off-by: Harold Gray [email protected]