Skip to content

check anonymous OPTIONS requests file in root (not in subdir)#13354

Merged
MorrisJobke merged 1 commit intonextcloud:stable15from
BastienDurel:caldav_anon_pb
Jan 4, 2019
Merged

check anonymous OPTIONS requests file in root (not in subdir)#13354
MorrisJobke merged 1 commit intonextcloud:stable15from
BastienDurel:caldav_anon_pb

Conversation

@BastienDurel
Copy link
Contributor

@BastienDurel BastienDurel commented Jan 4, 2019

Don't allow anonymous OPTIONS to sub directories, so we won't send 404's when client is expecting 401 before authenticate.

@BastienDurel BastienDurel mentioned this pull request Jan 4, 2019
Closed
@rullzer
Copy link
Member

rullzer commented Jan 4, 2019

Can you point me to the part of the RFC that says we should not allow options in subdirs?

@BastienDurel
Copy link
Contributor Author

BastienDurel commented Jan 4, 2019 •
edited
Loading

I cannot, but as the "real" tree is not used, all OPTIONS returns 404's
(I mean, in OPTIONS requests in subdirs)

@rullzer
Copy link
Member

rullzer commented Jan 4, 2019

Ah it is just for anonymous options... right 👍

@rullzer rullzer added the 3. to review Waiting for reviews label Jan 4, 2019
@rullzer rullzer added this to the Nextcloud 16 milestone Jan 4, 2019
MorrisJobke
MorrisJobke reviewed Jan 4, 2019
View reviewed changes
@BastienDurel
check anonymous OPTIONS requests file in root (not in subdir)
625380e 
Signed-off-by: Bastien Durel <bastien@durel.org>
MorrisJobke
MorrisJobke approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@MorrisJobke
Copy link
Member

MorrisJobke commented Jan 4, 2019

CI failures are unrelated -> merging.

@MorrisJobke MorrisJobke merged commit aaba0ad into nextcloud:stable15 Jan 4, 2019
@welcome
Copy link

welcome bot commented Jan 4, 2019

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

@MorrisJobke MorrisJobke mentioned this pull request Jan 4, 2019
Merged
3 tasks
@rullzer
Copy link
Member

rullzer commented Jan 4, 2019

/backport to stable15

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jan 4, 2019

The backport to stable15 failed. Please do this backport manually.

@BastienDurel
Copy link
Contributor Author

BastienDurel commented Jan 4, 2019

The PR targeted stable15 already

@MorrisJobke
Copy link
Member

MorrisJobke commented Jan 4, 2019

/backport to master

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 4, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jan 4, 2019

backport to master in #13362

@rullzer rullzer mentioned this pull request Jan 5, 2019
Closed
@georgehrke
Copy link
Member

georgehrke commented Jan 13, 2019

/backport to stable14

@georgehrke
Copy link
Member

georgehrke commented Jan 13, 2019

The branch that introduced this bug was back ported to 14, back porting the fix to 14 as well: #12639

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 13, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jan 13, 2019

backport to stable14 in #13558

@Hobbes921 Hobbes921 mentioned this pull request Apr 24, 2020
Closed
@ghost ghost mentioned this pull request Apr 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 15.0.1

Development

Successfully merging this pull request may close these issues.

4 participants

@BastienDurel @rullzer @MorrisJobke @georgehrke