[stable15] groupname like username - allow share with both#14709
Merged
MorrisJobke merged 3 commits intostable15from Mar 20, 2019
unknown repository
Merged
[stable15] groupname like username - allow share with both#14709MorrisJobke merged 3 commits intostable15from unknown repository
MorrisJobke merged 3 commits intostable15from
unknown repository
Conversation
Signed-off-by: Christian Aigner <[email protected]>
MorrisJobke
reviewed
Mar 20, 2019
MorrisJobke
reviewed
Mar 20, 2019
MorrisJobke
added
2. developing
Member
|
/backport to master |
Member
|
Usually we first develop something against master and then backport to the stable branches. But for this one it's okay to do it the other way around. |
fixed tabulator Co-Authored-By: aignerat <[email protected]>
tabulator change Co-Authored-By: aignerat <[email protected]>
MorrisJobke
approved these changes
Mar 20, 2019
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Code makes sense and works 👍
MorrisJobke
added
4. to release
Member
Status of 17173: failureTESTS=acceptance, TESTS-ACCEPTANCE=app-files-sharing
TESTS=acceptance, TESTS-ACCEPTANCE=app-files-sharing-link
|
MorrisJobke
changed the title
|
backport to master in #14766 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It happens that users and groups have the same name in big organizations, the nextcloud standard behaviour is like this: I can only share with the user or the group.
With this small extension it's possible to share files with the group "test" and the user "test" at the same time.
I added this feature, because it makes no sense to me to disallow the sharing because of the same name of a group and an user.