Skip to content

Make regions translatable #14853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Mar 26, 2019
Merged

Make regions translatable #14853

MorrisJobke merged 1 commit into from
Mar 26, 2019

Conversation

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Mar 26, 2019

Together with nextcloud/docker-ci@f24eb13 this properly extracts and localizes the locale regions

@MorrisJobke
Make regions translatable
db20f08 
Signed-off-by: Morris Jobke <[email protected]>
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Mar 26, 2019
@MorrisJobke MorrisJobke added this to the Nextcloud 16 milestone Mar 26, 2019
@MorrisJobke
Copy link
Member Author

MorrisJobke commented Mar 26, 2019

/backport to stable15

@MorrisJobke
Copy link
Member Author

MorrisJobke commented Mar 26, 2019

For #14822

georgehrke
georgehrke approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@georgehrke georgehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐘

rullzer
rullzer approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

But is the locale actually somewhere in text? Else it can't be translated?

@MorrisJobke
Copy link
Member Author

MorrisJobke commented Mar 26, 2019

But is the locale actually somewhere in text? Else it can't be translated?

See nextcloud/docker-ci@f24eb13

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 26, 2019
@MorrisJobke MorrisJobke merged commit fce1ddc into master Mar 26, 2019
@MorrisJobke MorrisJobke deleted the fix/14822/make-regions-translatable branch March 26, 2019 11:08
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 26, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Mar 26, 2019

backport to stable15 in #14859

@rullzer rullzer mentioned this pull request Mar 26, 2019
Merged
9 tasks
@Valdnet Valdnet mentioned this pull request Aug 30, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@georgehrke georgehrke georgehrke approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

4 participants

@MorrisJobke @rullzer @georgehrke