fix searching all users in repair regenerate birthday cal reparir job

[blizzz]

The problem: my dev system on upgrade is working on that for almost an hour now…

• this avoids searches across all users on all backends
• most, if not all, are known anyhow
• for those that aren't there is no reason to act upon
• with only known users it will be tremendeously faster… but it would still be best if this could be done in a background job instead and not blocking upgrade

[georgehrke]

Would it be better to replace this as well?

server/apps/dav/lib/Controller/BirthdayCalendarController.php

Line 96 in 5382eec

$this->userManager->callForAllUsers(function(IUser $user) {

[blizzz]

Would it be better to replace this as well?

server/apps/dav/lib/Controller/BirthdayCalendarController.php

Line 96 in 5382eec
$this->userManager->callForAllUsers(function(IUser $user) {

aye

[blizzz]

and found two other spots

[blizzz]

@georgehrke but is there a reason to have it a repair step, not a background job that can be run once after upgrade is done?

[blizzz]

Anyway, i think we should merge and backport it, otherwise setups with a serious backend will have a long lasted upgrade. For .1 we can perhaps turn it to background job if possible.

[georgehrke]

@schiessle Will this have any negative effect on federation?

[blizzz]

why should this affect federation? allForSeenUsers cycles over all known users. callForAllUsers might bring in new ones, but in any case it brings in a lot of overhead.

[georgehrke]

syncInstance syncs the address book containing all users for federation. So instead of all users only users that have logged in before will be synced (i assume).

[blizzz]

No, all the users known to Nextcloud. This can be more than have logged in.

[georgehrke]

but is there a reason to have it a repair step, not a background job that can be run once after upgrade is done?

The migration step doesn't generate all the birthday calendars itself, it only registers jobs to generate them later on in the background.

[blizzz]

The migration step doesn't generate all the birthday calendars itself, it only registers jobs to generate them later on in the background.

Then, this should be fine. Search external backends is expensive.

[blizzz]

/backport to stable16

[backportbot-nextcloud]

backport to stable16 in #15219