[Stable16] Fix mobile vertical scrolling#15469
Merged
MorrisJobke merged 1 commit intostable16from May 9, 2019
Merged
Conversation
skjnldsv
requested review from
ChristophWurst,
MorrisJobke,
jancborchardt,
juliusknorr and
rullzer
skjnldsv
changed the title
MorrisJobke
approved these changes
May 9, 2019
Member
Author
|
For some reasons it changed some compiled files in settings 🤷♂️ |
Member
This causes CI to fail :/ |
MorrisJobke
force-pushed
the
stb16/fix/mobile/scrolling
branch
from
5fe5116 to
3f72d04
Compare
Contributor
|
Looks like the node_modules are wrong. Try |
MorrisJobke
added
4. to release
Member
Could also that another PR didn't updated it, or am I wrong here? |
Member
Do you have |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
stb16/fix/mobile/scrolling
branch
from
3f72d04 to
8f56f69
Compare
Member
Author
That was it! 🎉 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #15462