Add interfaces to interact with subscription from support app#15495
Merged
MorrisJobke merged 1 commit intomasterfrom May 13, 2019
Merged
Add interfaces to interact with subscription from support app#15495MorrisJobke merged 1 commit intomasterfrom
MorrisJobke merged 1 commit intomasterfrom
Conversation
MorrisJobke
requested review from
ChristophWurst,
blizzz,
nickvergessen and
rullzer
Member
Author
|
I'm also happy to adjust the names of the interfaces or methods. |
ChristophWurst
approved these changes
May 10, 2019
MorrisJobke
force-pushed
the
feature/noid/support-app-integration
branch
from
e605a18 to
e32e10d
Compare
Member
Author
|
Just that you know: I will most likely remove all unneeded methods in here again (it seems that as of now only |
MorrisJobke
force-pushed
the
feature/noid/support-app-integration
branch
from
e32e10d to
ff82e98
Compare
Signed-off-by: Morris Jobke <[email protected]>
MorrisJobke
force-pushed
the
feature/noid/support-app-integration
branch
from
ff82e98 to
83b00a9
Compare
MorrisJobke
added
backport-request
4. to release
Member
Author
Done 👍 |
Member
Author
|
/backport to stable16 |
|
backport to stable16 in #15513 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build around the concept that @ChristophWurst already integrated for the sentry app.
It could be that we will backport those new interfaces down to stable14 to allow this nice integration of supported apps, etc. there as well.
The code in here is fully tested.