Change text color in search box in darktheme, ref #15598#15705
Merged
MorrisJobke merged 1 commit intomasterfrom May 28, 2019
Merged
Change text color in search box in darktheme, ref #15598#15705MorrisJobke merged 1 commit intomasterfrom
MorrisJobke merged 1 commit intomasterfrom
Conversation
ChristophWurst
added
3. to review
ChristophWurst
added
2. developing
GretaD
force-pushed
the
bugfix/15598/text-color-search-box-darktheme
branch
from
7c10ef6 to
285057c
Compare
Signed-off-by: Greta Doci <[email protected]>
GretaD
force-pushed
the
bugfix/15598/text-color-search-box-darktheme
branch
from
285057c to
bb811ee
Compare
jancborchardt
approved these changes
May 28, 2019
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Tested and looks good 👍
Member
|
@ChristophWurst @GretaD it’s set to "developing", anything left to do? Cause it does seem to work nicely. cc @nextcloud/designers for review. :) |
Member
|
CI failures are only timeouts -> good to be merged. |
Member
I guess that was fixed after @ChristophWurst changed it to that. Let's merge it as it is working as expected. |
Member
|
/backport to stable16 |
|
backport to stable16 in #15768 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need to fix the color-primary-text variable so it is inverted when the primary-colour is too bright as suggested by skjnldsv here: 7c10ef6. Another patch will follow.
Fixes #15598