cache loginName2UserName and cover the method with unit tests#1643
Merged
MorrisJobke merged 2 commits intomasterfrom Oct 7, 2016
Merged
cache loginName2UserName and cover the method with unit tests#1643MorrisJobke merged 2 commits intomasterfrom
MorrisJobke merged 2 commits intomasterfrom
Conversation
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
|
@blizzz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @invalid-email-address and @butonic to be potential reviewers. |
Member
Author
|
Somehow I cannot assingn the milestone?! |
Member
Me neither… |
Member
|
Does the trick for me! |
Member
|
Tested and works for me 👍 |
MorrisJobke
approved these changes
Oct 7, 2016
Member
Author
|
A candidate for backporting. Not a serious issue, but fixing the missing caching for that method brings cyber-performance benefits. @karlitschek |
Member
|
To put it in numbers: Without that nearly every request takes 470ms longer on cloud.nextcloud.com because it does quite some LDAP queries. 🙈 |
Member
|
👍 |
blizzz
added a commit
that referenced
this pull request
Oct 7, 2016
get rid of test warnings Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de> cache loginName2UserName and cover the method with unit tests Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de> adjust tests Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Member
Author
|
Backport is here: #1654 |
blizzz
added a commit
that referenced
this pull request
Oct 7, 2016
get rid of test warnings Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de> cache loginName2UserName and cover the method with unit tests Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de> adjust tests Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@LukasReschke saw a code path that was talking to LDAP on any request. Turns out, it did not cache the result. Covered by unit tests, please review. @nextcloud/ldap