use older php array syntax in index.php

[georgehrke]

We should use the old array syntax in the index.php, because the shorthand version was introduced with PHP 5.4.
Users with an older PHP will only see an error message about the Syntax error in the index.php

fixes #1659

please review @MorrisJobke @nickvergessen @fancycode

[mention-bot]

@georgehrke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @owncloud-bot and @LukasReschke to be potential reviewers.

[rullzer]

Why? we don't support it.

[georgehrke]

Yes, we don't support it.
But if we use this [] syntax, 5.3 won't even know, that we only support 5.6+.
They'll only see an HTTP 500

[nickvergessen]

I don't really care. Either way is fine for me. We could also add the exact parse error in our docs, so it has a hint on google...

[rullzer]

mmm fine by me. But it will fail at some point in the future when somebody modifies base.php again.

[georgehrke]

mmm fine by me. But it will fail at some point in the future when somebody modifies base.php again.

I don't think so. As long as this check kicks on, base.php won't even be included.

server/index.php

Line 30 in a48aed2

if (version_compare(PHP_VERSION, '5.6.0') === -1) {

My point is, that the user won't even see:

This version of Nextcloud requires at least PHP 5.6.0<br/>
You are currently running ' . PHP_VERSION . '. Please update your PHP version.

when running on PHP5.3 or earlier, because php isn't even able to parse the index.php

[LukasReschke]

LGTM