Conversation
Member
Author
|
/backport to stable17 |
georgehrke
added
3. to review
georgehrke
changed the title
Signed-off-by: Georg Ehrke <[email protected]>
georgehrke
force-pushed
the
bugfix/noid/properly_mark_birthday_calendars_as_not_sharable
branch
from
a0d4936 to
b0a3782
Compare
rullzer
approved these changes
Sep 17, 2019
rullzer
deleted the
bugfix/noid/properly_mark_birthday_calendars_as_not_sharable
branch
|
backport to stable17 in #17184 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DAV Sharing plugin enforces an (arbitrary) check for the calendar to be writeable: https://github.com/nextcloud/server/blob/master/apps/dav/lib/DAV/Sharing/Plugin.php#L166
This should ideally be fixed, but is something to look into for Nextcloud 18. In the meantime, properly mark the birthday calendar as not shareable.