Throw an invalid token exception is token is marked outdated#17443
Merged
Throw an invalid token exception is token is marked outdated#17443
Conversation
rullzer
added
3. to review
Member
Author
|
I think this is good to go :) |
lib/private/Authentication/Exceptions/PasswordExpiredTokenException.php
Outdated
Show resolved
Hide resolved
ChristophWurst
approved these changes
Nov 12, 2019
Member
Author
|
Review time @blizzz this should help a bit with locked out LDAP stuff. |
Member
Yes, when password changed on the backend. But it used to be working iirc? |
This comment has been minimized.
This comment has been minimized.
This avoids hitting the backend with multiple requests for the same token. And will help avoid quick LDAP lockouts. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
ChristophWurst
force-pushed
the
enh/expired_token_on_invalid_pass
branch
from
35facfc to
b371e73
Compare
Member
|
/backport to stable17 |
|
backport to stable17 in #18198 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids hitting the backend with multiple requests for the same
token. And will help avoid quick LDAP lockouts.