Conversation
e8becfd to
6c27b5a
Compare
Member
|
@rullzer I did the front, but there is one thing that was used that is not compliant to your new config: |
Member
Author
right. Let me fix that. Thanks for the work. |
skjnldsv
approved these changes
Dec 5, 2019
ff21cdd to
49f4e3d
Compare
Member
|
Rebased |
Member
|
@rullzer one more test to make sure everything is how you wanted? |
Signed-off-by: Roeland Jago Douma <[email protected]>
Signed-off-by: Roeland Jago Douma <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
49f4e3d to
9b82225
Compare
Member
Author
|
Fixed the tests. @skjnldsv it does what it should do it hink. What I find weird is that when you press search globally that the dropdown vanishes and you don't get proper feedback 'no results found' or something. But lets get this in and fix that later.. |
Member
Author
|
We should backport the functinality to 17 and 16 (maybe even 15) but will require manual work. |
This was referenced Dec 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.