Prevent duplicate entries in file sidebar#18764
Merged
Conversation
gary-kim
added
bug
3. to review
Member
|
master is NC19 now. |
Contributor
|
/backport to stable18 |
Contributor
|
Conflicts 😨 |
kesselb
added
4. to release
Signed-off-by: Gary Kim <[email protected]>
gary-kim
force-pushed
the
fix/18744/duplicate-activity-sidebar
branch
from
98e4225 to
d8881fa
Compare
Member
Author
|
Rebased |
|
The backport to stable18 failed. Please do this backport manually. |
MorrisJobke
added a commit
that referenced
this pull request
Jul 21, 2020
Those tests are actual problems in our code. See #20462 (comment) for a summary by @danxuliu Basically they are introduced by #18929 but are only revealed by #18764. Signed-off-by: Morris Jobke <[email protected]>
This was referenced Jul 21, 2020
backportbot-nextcloud bot
pushed a commit
that referenced
this pull request
Jul 21, 2020
Those tests are actual problems in our code. See #20462 (comment) for a summary by @danxuliu Basically they are introduced by #18929 but are only revealed by #18764. Signed-off-by: Morris Jobke <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18744
The watcher on
activeTabwill callsetFileInfowhen mounting so thebeforeMounthook is not required.Tested on my machine with the activity app and haven't run into issues but not entirely sure if there are maybe other cases in which the hook is required?