Caching and compression for app store requests#21050
Conversation
|
/backport to stable19 |
|
/backport to stable18 |
|
/backport to stable17 |
|
/backport to stable16 |
|
The tests say no |
Signed-off-by: Morris Jobke <[email protected]>
In test it reduced the transfered data from 5 MB to 2 MB. This should reduce the load on the appstore significantly. Signed-off-by: Morris Jobke <[email protected]>
c64fd31 to
6ffde12
Compare
I fixed them :) Wasn't as easy as a lot of logic was hidden in |
|
I wonder if this should be generally the default for our http client. Would there be any downside to that? |
Not really actually. Saying that we support gzip is fine IMO |
I would keep it like that for the backports and enable it for 20 in the default client? |
|
CI is fine -> merge |
|
While looking into our apps.nextcloud.com server I realized that the requests are not compressed. Even if the server supports it the clients don't request it. Thus the server sends out 5 MB instead of the compressed 2 MB. This and the raised cache time of 60 instead of 5 minutes should reduce the overall load of the app store server quite a lot.
As those are quite small changes I would backport them down to stable16.