Improve CertificateManager to not be user context dependent#21693
Improve CertificateManager to not be user context dependent#21693MorrisJobke merged 4 commits intomasterfrom
Conversation
Yeah so the mroe I think about the harder it is. |
eb0c4c6 to
824844d
Compare
|
Rebases and pushed another commit to fix other parts of the system as well. |
824844d to
636a93b
Compare
|
While digging through the code I found that the controller was removed in #21224. I will check when the routes and UI was removed to give some estimates on the usage. |
636a93b to
4e556b9
Compare
|
Fixed the tests, added a one time background job, added texts for the setup checks and rebased and squashed everything. Ready for review IMO. I also added a screenshot to the OP. |
* removes the ability for users to import their own certificates (for external storage) * reliably returns the same certificate bundles system wide (and not depending on the user context and available sessions) The user specific certificates were broken in some cases anyways, as they are only loaded if the specific user is logged in and thus causing unexpected behavior for background jobs and other non-user triggered code paths. Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Just check in the certifcate manager. So every part of the system that request the certificatebundle gets the defaullt one (the 99% case) if we can. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
4e556b9 to
4592cdd
Compare
…ificates and shows a warning in the admin settings Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
4592cdd to
9435ec2
Compare
|
Fixed the tests. Ready for review 🚀 |
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 34946: failuremysql5.6-php7.3Show full log |
The user specific certificates were broken in some cases anyways, as they are only loaded if the specific user is logged in and thus causing unexpected behavior for background jobs and other non-user triggered code paths.