[stable18] Improve error reporting on sharing errors

[backportbot-nextcloud]

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #21748

[skjnldsv]

@nickvergessen please have a look at potential missing code

[rullzer]

Lets wait for the 18.0.8 cycle

[nickvergessen]

please have a look at potential missing code

It's just missing compiling. But let's do that when we can merge it afterwards.

[rullzer]

/compile amend /

[MorrisJobke]

/compile amend /

[skjnldsv]

Lots of failures

[rullzer]

/compile amend /

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31042: failure

mariadb10.1-php7.2

Show full log

There were 8 warnings:

1) Test\DB\DBSchemaTest::testSchema
Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.

2) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "all" (array(0, 1, 2, 3), array(), array())
The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.

3) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "only-todos" (array(), array('VTODO'), array())
The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.

4) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "only-events" (array(0, 1, 2, 3), array(), array(array('VEVENT', false, array(), array(null, null), array())))
The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.

5) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "start" (array(1, 2, 3), array(), array(array('VEVENT', false, array(), array(DateTime Object (...), null), array())))
The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.

6) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "end" (array(0), array(), array(array('VEVENT', false, array(), array(null, DateTime Object (...)), array())))
The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.

7) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "future" (array(3), array(), array(array('VEVENT', false, array(), array(DateTime Object (...), null), array())))
The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.

8) OCA\FederatedFileSharing\Tests\FederatedShareProviderTest::testCreate
assertArraySubset() is deprecated and will be removed in PHPUnit 9.

--

There was 1 failure:

1) Test\Files\ObjectStore\ObjectStoreStorageTest::testCopyFromSameStorage with data set #2 ('/source with space.txt', '/target.txt')
Expected /target.txt to be a copy of /drone/src/tests/data/lorem.txt
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.\n
-Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.\n
-Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur.\n
-Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.'
+''

/drone/src/tests/lib/Files/Storage/Storage.php:207
/drone/src/tests/lib/Files/Storage/Storage.php:585

--

There was 1 risky test:

1) OCA\TwoFactorBackupCodes\Tests\Db\BackupCodeMapperTest::testInsertArgonEncryptedCodes
This test did not perform any assertions

/drone/src/apps/twofactor_backupcodes/tests/Db/BackupCodeMapperTest.php:115

acceptance-app-comments

• tests/acceptance/features/app-comments.feature:288

Show full log

  Scenario: open a search result for a comment in a folder named like its child folder # /drone/src/tests/acceptance/features/app-comments.feature:288
    Given I am logged in                                                               # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "Folder"                                           # FileListContext::iCreateANewFolderNamed()
    And I open the details view for "Folder"                                           # FileListContext::iOpenTheDetailsViewFor()
    And I open the "Comments" tab in the details view                                  # FilesAppContext::iOpenTheTabInTheDetailsView()
    And I create a new comment with "Hello world" as message                           # CommentsAppContext::iCreateANewCommentWithAsMessage()
    And I see a comment with "Hello world" as message                                  # CommentsAppContext::iSeeACommentWithAsMessage()
    And I enter in the folder named "Folder"                                           # FileListContext::iEnterInTheFolderNamed()
    And I create a new folder named "Folder"                                           # FileListContext::iCreateANewFolderNamed()
    And I open the Files app                                                           # FilesAppContext::iOpenTheFilesApp()
    When I search for "hello"                                                          # SearchContext::iSearchFor()
    And I open the search result 1                                                     # SearchContext::iOpenTheSearchResult()
    Then I see that the details view is open                                           # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I see that the file name shown in the details view is "Folder"                 # FilesAppContext::iSeeThatTheFileNameShownInTheDetailsViewIs()
      Failed asserting that two strings are equal.
      --- Expected
      +++ Actual
      @@ @@
      -''
      +'Folder'
    And I see a comment with "Hello world" as message                                  # CommentsAppContext::iSeeACommentWithAsMessage()
    And I see that the file list is currently in "Home"                                # FileListContext::iSeeThatTheFileListIsCurrentlyIn()
    And I see that the file list contains a file named "welcome.txt"                   # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I see that the file list contains a file named "Folder"                        # FileListContext::iSeeThatTheFileListContainsAFileNamed()