LDAP: remove unused methods and DB values#22583
Merged
Conversation
blizzz
requested review from
ChristophWurst,
juliusknorr,
nickvergessen and
rullzer
Member
Author
|
/backport to stable19 |
Member
Author
|
/backport to stable18 |
blizzz
force-pushed
the
fix/noid/remove-unused-code
branch
2 times, most recently
from
64341f1 to
18c6b98
Compare
This comment has been minimized.
This comment has been minimized.
- only references were in unit tests Signed-off-by: Arthur Schiwon <[email protected]>
juliusknorr
reviewed
Sep 4, 2020
blizzz
force-pushed
the
fix/noid/remove-unused-code
branch
from
18c6b98 to
bb02c29
Compare
juliusknorr
approved these changes
Sep 4, 2020
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Small naming suggestion, otherwise 👍
… prefs - also removes related app setting "updateAttributesInterval" Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
force-pushed
the
fix/noid/remove-unused-code
branch
from
bb02c29 to
aa2d754
Compare
blizzz
added
4. to release
This was referenced Sep 6, 2020
Open
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were still having the
update()method on LDAP'sUserclass as well as related values we stored with the users. In the past we changed updating of user records to happen initially (on first importing), in the background, and on login. The use case to do it inline was not given anymore.update()was now only referenced by unit tests. It made use of some other methods and also of thelastFeatureRequestmarker in the database. This is not needed anymore, and thus we do not need to write it anymore on every background run. The repair steps take care of removing these rows from the database.