Conversation
…ontaining @ Before when you have a user "smith" and a federated user "[email protected]" you could see the federation result with "smit" but not with "smith" anymore. With most LDAP configurations and local backend setups this is disturbing and causes issues. The idea of not showing the email and federation on a matching user was with: Local user registered with "[email protected]" user id and having that same email / cloud id in your contacts addressbook. So we now only hide those "side results" when the search does contain an @ Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
added
bug
3. to review
nickvergessen
requested review from
ChristophWurst,
MorrisJobke,
blizzz,
icewind1991 and
rullzer
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 33321: failuremysql8.0-php7.4
postgres11-php7.4
|
Member
Author
|
/backport to stable20 |
Member
Author
|
/backport to stable19 |
Member
Author
|
/backport to stable18 |
ChristophWurst
approved these changes
Sep 29, 2020
rullzer
deleted the
bugfix/noid/show-federation-results-with-the-same-name
branch
This was referenced Sep 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ontaining @
Before when you have a user "smith" and a federated user "[email protected]"
you could see the federation result with "smit" but not with "smith" anymore.
With most LDAP configurations and local backend setups this is disturbing and
causes issues.
The idea of not showing the email and federation on a matching user was with:
Local user registered with "[email protected]" user id and having that same
email / cloud id in your contacts addressbook. So we now only hide those
"side results" when the search does contain an @