Fix sidebar updateTabs method

[skjnldsv]

Needed for 20! ⚠️
Fix nextcloud/photos#467

[skjnldsv]

/compile amend /

[skjnldsv]

skjnldsv changed the title improve handling of out of space errors for smb Fix sidebar updateTabs method maintenant

Go home Github, you're drunk!

[skjnldsv]

/compile amend /

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 33838: failure

mysql5.6-php7.2

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\Files_Versions\Tests\VersioningTest::testRestoreMovedShare
File content has not changed
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'version 2'
+'version 1'

/drone/src/apps/files_versions/tests/VersioningTest.php:729

acceptance-app-files

• tests/acceptance/features/app-files.feature:108

Show full log

  Scenario: show shares                                               # /drone/src/tests/acceptance/features/app-files.feature:108
    Given I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt"                            # FilesAppSharingContext::iShareTheLinkFor()
    When I open the "Shares" section                                  # AppNavigationContext::iOpenTheSection()
    Then I see that the current section is "Shares"                   # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
      Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)

[MorrisJobke]

/backport to stable20

[skjnldsv]

@MorrisJobke that was on stable20

[skjnldsv]

master have it alongside other changes, I backported this only

[backportbot-nextcloud]

The backport to stable20 failed. Please do this backport manually.

[MorrisJobke]

🙈