Skip to content

[stable20] Fix greatest/least order for oracle#23975

Merged
MorrisJobke merged 4 commits intostable20from
backport/23923/stable20
Nov 9, 2020
Merged

[stable20] Fix greatest/least order for oracle#23975
MorrisJobke merged 4 commits intostable20from
backport/23923/stable20

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Nov 7, 2020

backport of #23923

@nickvergessen @backportbot
Fix order of GREATEST for Oracle
d111e88 
As per https://docs.oracle.com/cd/B19306_01/server.102/b14200/functions060.htm
Oracle uses the first value to cast the rest or the values.
So when the first value is a plain int, instead of doing the math,
it will cast the expression to int and continue with a potential 0.

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen @backportbot
Use Query builder function
c71cc68 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen @backportbot
Make sure Oracle always casts everything in the best way
2e3cffc 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen @backportbot
Update parameters
b3dfa92 
Signed-off-by: Joas Schilling <[email protected]>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 20.0.2 milestone Nov 7, 2020
@faily-bot
Copy link

faily-bot bot commented Nov 7, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 35218: failure

mariadb10.4-php7.3

Show full log 
There was 1 error:

1) OCA\DAV\Tests\unit\Connector\Sabre\RequestTest\EncryptionUploadTest::testChunkedUploadOverWrite
TypeError: Argument 2 passed to OCA\DAV\Events\CalendarCreatedEvent::__construct() must be of the type array, null given, called in /drone/src/apps/dav/lib/CalDAV/CalDavBackend.php on line 790

/drone/src/apps/dav/lib/Events/CalendarCreatedEvent.php:51
/drone/src/apps/dav/lib/CalDAV/CalDavBackend.php:790
/drone/src/apps/dav/lib/HookManager.php:157
/drone/src/apps/dav/lib/AppInfo/Application.php:131
/drone/src/3rdparty/symfony/event-dispatcher/EventDispatcher.php:264
/drone/src/3rdparty/symfony/event-dispatcher/EventDispatcher.php:239
/drone/src/3rdparty/symfony/event-dispatcher/EventDispatcher.php:73
/drone/src/lib/private/EventDispatcher/SymfonyAdapter.php:85
/drone/src/lib/private/User/Session.php:569
/drone/src/lib/private/User/Session.php:415
/drone/src/lib/private/User/Session.php:624
/drone/src/lib/private/User/Session.php:367
/drone/src/apps/dav/tests/unit/Connector/Sabre/RequestTest/Auth.php:84
/drone/src/3rdparty/sabre/dav/lib/DAV/Auth/Plugin.php:192
/drone/src/3rdparty/sabre/dav/lib/DAV/Auth/Plugin.php:144
/drone/src/3rdparty/sabre/event/lib/WildcardEmitterTrait.php:89
/drone/src/3rdparty/sabre/dav/lib/DAV/Server.php:458
/drone/src/3rdparty/sabre/dav/lib/DAV/Server.php:251
/drone/src/3rdparty/sabre/dav/lib/DAV/Server.php:319
/drone/src/apps/dav/tests/unit/Connector/Sabre/RequestTest/RequestTestCase.php:134
/drone/src/apps/dav/tests/unit/Connector/Sabre/RequestTest/RequestTestCase.php:116
/drone/src/apps/dav/tests/unit/Connector/Sabre/RequestTest/UploadTest.php:123

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

@rullzer rullzer mentioned this pull request Nov 9, 2020
Merged
@MorrisJobke MorrisJobke merged commit 40c4d24 into stable20 Nov 9, 2020
@MorrisJobke MorrisJobke deleted the backport/23923/stable20 branch November 9, 2020 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

Nextcloud 20.0.2

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer @MorrisJobke @nickvergessen