dont use system composer for autoload checker#24396
Merged
MorrisJobke merged 3 commits intomasterfrom Dec 2, 2020
Merged
Conversation
this ensures that the same composer version is used by everyone (and ci) Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Member
|
didn't see it was two commits and the changes of the first one are buried in the overall diff |
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 35997: failurecheckers
|
This comment has been minimized.
This comment has been minimized.
Member
Please remove the file after the autoloader is dumped when it was downloaded before. No need to add a remove statement to the release script for a file that is only temporarily there in one CI step. |
Signed-off-by: Robin Appelman <robin@icewind.nl>
MorrisJobke
approved these changes
Dec 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this ensures that the same composer version is used by everyone (and ci) which prevents issues where a local composer version generates different autoloader files than the one used by ci.