Skip to content

dont use system composer for autoload checker#24396

Merged
MorrisJobke merged 3 commits intomasterfrom
dont-use-system-composer
Dec 2, 2020
Merged

dont use system composer for autoload checker#24396
MorrisJobke merged 3 commits intomasterfrom
dont-use-system-composer

Conversation

@icewind1991
Copy link
Member

this ensures that the same composer version is used by everyone (and ci) which prevents issues where a local composer version generates different autoloader files than the one used by ci.

this ensures that the same composer version is used by everyone (and ci)

Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Nov 26, 2020
@icewind1991 icewind1991 added this to the Nextcloud 21 milestone Nov 26, 2020
@ChristophWurst
Copy link
Member

ChristophWurst commented Nov 26, 2020

but how do we make sure everyone has the same local version of the composer.phar? is it always assumed to be the latest? What about stableXYZ branches?

didn't see it was two commits and the changes of the first one are buried in the overall diff

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works :)

@faily-bot
Copy link

faily-bot bot commented Nov 26, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 35997: failure

checkers

@ChristophWurst

This comment has been minimized.

@MorrisJobke
Copy link
Member

ERROR: Please remove or add those files again or inform the release team about those now files to be included or excluded from the release tar ball.

Release team notified.

Please remove the file after the autoloader is dumped when it was downloaded before. No need to add a remove statement to the release script for a file that is only temporarily there in one CI step.

Signed-off-by: Robin Appelman <robin@icewind.nl>
@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 2, 2020
@MorrisJobke MorrisJobke merged commit 32f6bdf into master Dec 2, 2020
@MorrisJobke MorrisJobke deleted the dont-use-system-composer branch December 2, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants