set mountid for personal external storage mounts

[icewind1991]

Signed-off-by: Robin Appelman robin@icewind.nl

[icewind1991]

/backport to stable20

[icewind1991]

/backport to stable19

[MorrisJobke]

@icewind1991 Any more info on how to test this?

[MorrisJobke]

And what it fixes.

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 49: failure

mariadb10.1-php7.3

Show full log

There was 1 error:

1) Test\Files\ObjectStore\ObjectStoreStorageTest::testCopyOverwrite with data set #4 ('/source.txt', '/tärgét.txt')
copy(/tmp/oc_tmp_QUPeoP-folder/urn:oid:1229): failed to open stream: No such file or directory

/drone/src/lib/private/Files/Storage/Local.php:351
/drone/src/lib/private/Files/ObjectStore/StorageObjectStore.php:98
/drone/src/lib/private/Files/ObjectStore/ObjectStoreStorage.php:579
/drone/src/lib/private/Files/ObjectStore/ObjectStoreStorage.php:560
/drone/src/lib/private/Files/ObjectStore/ObjectStoreStorage.php:542
/drone/src/tests/lib/Files/Storage/Storage.php:259

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

[icewind1991]

I ran into this with permissions_overwrite which uses the mountid to identity external storage and register storage wrappers for specific external storages, this didn't work for user configured storages since they didn't have the mount id set (i have also worked around the issue for now in the app).

In general this is an issue for any code that tries to map mountpoints/storages to an external storage configuration

[rullzer]

Seems fine