Conversation
juliusknorr
force-pushed
the
enh/share-deck
branch
2 times, most recently
from
e5533e7 to
4ac2cbb
Compare
juliusknorr
requested review from
ChristophWurst,
danxuliu,
nickvergessen and
rullzer
| } elseif ($shareType === IShare::TYPE_DECK) { | ||
| $provider = $this->getProvider('deck'); |
There was a problem hiding this comment.
We could also extend the share manager to allow registering a share provider together with a shareType, then at least the provider registration could be done without having additional code in server (except for the actual shareType constant), but i kept that for later to not overcomplicate this pr.
There was a problem hiding this comment.
'deck' is the identifier of the share provider https://github.com/nextcloud/deck/pull/2638/files#diff-bfa062609a398b64ebc3167faba3abbca19b04da0c1e3f3dd033fa6babaebbc4R100-R102 that basically implies that IShare::TYPE_DECK is used.
apps/files_sharing/lib/Controller/DeletedShareAPIController.php
Outdated
Show resolved
Hide resolved
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
🐘 looks like it could work. but didnt really test or check if all places have been adapted.
rullzer
left a comment
rullzer
left a comment
There was a problem hiding this comment.
Please check the comments from @nickvergessen but fine by me
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
…to have a link Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
enh/share-deck
branch
from
989f675 to
1fd2298
Compare
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
enh/share-deck
branch
from
1fd2298 to
c4ea37b
Compare
3 participants
This PR extends the share manager to allow apps registering their own share providers and implements support for deck shares in places where handing over the logic to the apps is yet not possible. Basically the parts where the server still needs app based logic is mainly the share api and the sharing sidebar in files.
Heavily inspired by #10255
Server part of nextcloud/deck#2638 This can already be tested together for the share provider logic, however the deck side is still lacking the user interface to interact with the shares and upload/share files from within deck.