Bump scssphp/scssphp to 1.8.1

[come-nc]

Signed-off-by: Côme Chilliet [email protected]

nextcloud/3rdparty#934

[come-nc]

Error: The method ScssPhp\ScssPhp\Compiler::toHSL is internal to ScssPhp but called from OCA\Theming\Util (see https://psalm.dev/175)

Can someone familiar enough look into https://scssphp.github.io/scssphp/docs/changelog.html and see how big the impact of this bump is?

We had 1.4.0 before so it’s a pretty big bump, I’m not sure if the psalm spotted problem is the only one.

[CarlSchwan]

I just did some small grepping and the only misused was the one reported by psaml and I fixed it. Other than that locally everything seems to still works and I followed https://scssphp.github.io/scssphp/docs/#security-considerations to do a bit of hardening

[skjnldsv]

We can merge but note that this scsscacher should go away as soon as we have the time to :)

[come-nc]

@skjnldsv You merged here but it was needed to merge nextcloud/3rdparty#934 first and then rebase here to use the merge commit.

[ChristophWurst]

@come-nc make your PR a draft next time 😉

[come-nc]

@come-nc make your PR a draft next time wink

But can it get approvals while still being a draft? I wait for CI and approvals on server side before merging 3rdparty side, I thought this was not possible with a draft.

[come-nc]

(3rdparty was merged, fixing PR server-side incoming)

[nickvergessen]

But can it get approvals while still being a draft?

yes