Use proper translation source for direct editing#30119
Merged
Conversation
juliusknorr
requested review from
a team,
azul,
icewind1991,
julien-nc,
mejo-,
nickvergessen and
skjnldsv
and removed request for
a team
CarlSchwan
approved these changes
Dec 6, 2021
nickvergessen
previously requested changes
Dec 6, 2021
nickvergessen
added
1. to develop
The 'Empty file' string is translated in `lib` - not in `core`. Signed-off-by: Azul <azul@riseup.net>
Contributor
|
Oh... I did not see this pr and opened #30298 I don't think there's a need for the user language option when getting l10n. At least I was able to confirm it works without it. I'm not sure if that's always the case though. Checking other files the language option is left out in most cases. |
azul
force-pushed
the
bugfix/noid/direct-editor-translation
branch
from
b4e3a42 to
8535dc4
Compare
azul
approved these changes
Dec 16, 2021
Contributor
azul
left a comment
azul
left a comment
There was a problem hiding this comment.
I investigated the issue and came to the same conclusion ... so I'd say it's good to go.
Member
Author
|
Yes, if null is used the current user will be fetched if available. |
azul
dismissed
nickvergessen’s stale review
Adjusted PR accordingly. Checked with @juliushaertl
Contributor
|
/backport to stable23 |
Contributor
|
/backport to stable22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translations are in
libinstead ofcoreMake sure that mobile apps show a translated version of "Empty file" instead of always using the English one.