Use less deprecated methods in base.php#30745
Conversation
artonge
force-pushed
the
fix/dont_use_deprecated_methods
branch
from
85113ff to
0ea689d
Compare
artonge
requested review from
a team,
come-nc,
juliusknorr and
nickvergessen
and removed request for
a team
The problem for me was quite easy:
|
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
fix/dont_use_deprecated_methods
branch
from
0ea689d to
b46ff97
Compare
|
Tested and it work, but I had to extract some |
artonge
added
bug
feature: install and update
javascript
3. to review
Works fine here even when I revert that change. |
|
|
||
| })(); | ||
|
|
||
| window.addEventListener('DOMContentLoaded', function() { |
There was a problem hiding this comment.
Why is this code in the typical (function() { from jquery?
There was a problem hiding this comment.
As per his comment:
Tested and it work, but I had to extract some
$call outside of a listener forDOMContentLoadedas it wasn't called for some reason. This should be safe asjQueryis set bycore-common.js.
But yeah works locally with reverting this change
There was a problem hiding this comment.
It works on chrome but not firefox 😕. Can someone confirm the behaviour on firefox?
There was a problem hiding this comment.
It works for me in Chromium and Firefox
There was a problem hiding this comment.
So let's revert for now, so psalm is happy again and then investigate further what's wrong with your FF?
Signed-off-by: Joas Schilling <[email protected]>
skjnldsv
added
4. to release
|
CI failure is unrelated. |
4 participants
Fix static analysis introduced by #30733
@nickvergessen can you confirm that this is working, I have no idea how to test the updater web UI :/