Declare header entries in the order they are displayed#32702
Merged
Conversation
The notifications entry was declared after the search one, but they are rendered in a different order. This PR switch their declarations, so the order they appear in match their order in the DOM. Signed-off-by: Louis Chemineau <[email protected]>
artonge
requested review from
a team,
PVince81,
Pytal and
skjnldsv
and removed request for
a team
7 tasks
Member
@CarlSchwan is requested at the front desk 🎤 |
artonge
force-pushed
the
fix/header_entries_order
branch
from
51f51d7 to
6905b34
Compare
Contributor
Author
🙈 |
Member
|
check with notifications app disabled |
Contributor
Author
Checked, it works |
skjnldsv
approved these changes
Jun 2, 2022
Pytal
approved these changes
Jun 2, 2022
Pytal
added
4. to release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The notifications' entry was declared after the search one, but they are rendered in a different order. This PR switch their declarations, so the order they appear in match their order in the DOM.
This also make more sense when navigating with the keyboard.