Allow to remove the background and select a custom colour + cypress

[skjnldsv]

Fix #34511
Fix #34449
Fix #34560

• Fix variables
• List use cases
• Add colour extract from custom background
• Add cypress testing and drop selenium
• Cleanup code

Later

• Figure out how to manage custom backgrounds and background-image-invert-if-bright
• Add migration for shipped background new background_color key
• Update Migration to use new background_image key
  optimize background image migration job #34677

[skjnldsv]

Let's go! Cypress tests are in and green!

I'm covering the following use cases:

• Checking the default background and colour of a new user
• Selecting a shipped background
• Removing the background
• Changing the primary color from a user
• Selecting a custom background and checking the extracted primary color

[skjnldsv]

1. it's definitely a bug.I might have missed something during the rebase
2. yes, we cannot go around that. We can't detect the top-header brightness of the image (not without an heavier mechanism)
3. a. can be adjusted later, it's a good question. I think it's good enough tbh. We could put it first maybe?
   b. also can be adjusted as a follow-up. We can add that easily sure 👍

[skjnldsv]

Is it intentional that the default background image is not shown on the login page?

Fixed

[artonge]

For photos, I made the action upload the snapshots folder. It helps to debug sometime. Feel free to add something like:

      - name: Upload snapshots
        uses: actions/upload-artifact@v3
        if: always() // maybe only for failing tests. Does failing() exists ?
        with:
          name: snapshots
          path: cypress/snapshots

[skjnldsv]

They are added on the cypress dashboard automatically

[skjnldsv]

https://cloud.cypress.io/organizations/07c47405-2e3c-4482-bc47-727f1737f458/projects

[artonge]

You're right, and I knew that at the time, can't remember why I added that then...

[artonge]

I remember now ! I was not about snapshots, but nextcloud logs:

     - name: Extract NC logs
        if: always()
        run: docker-compose --project-directory cypress logs > nextcloud.log

      - name: Upload NC logs
        uses: actions/upload-artifact@v3
        if: always()
        with:
          name: nc_logs_${{ matrix.containers }}
          path: nextcloud.log

[skjnldsv]

This is a good point!

[szaimen]

@skjnldsv

1. Is it intentional that the default background image is not shown on the login page?

Fixed

Great :)

2. yes, we cannot go around that. We can't detect the top-header brightness of the image (not without an heavier mechanism)

Okay, would be really good to fix this as it will always lead to problems. Shall I create a follow-up issue for this? But honestly it would be much better if that could be fixed directly in this PR...

3. a. can be adjusted later, it's a good question. I think it's good enough tbh. We could put it first maybe?

Yeah, putting it first would be better than the current behaviour, however I think it should be really separate from the grid...

b. also can be adjusted as a follow-up. We can add that easily sure 👍

Yes, would be really good to have that. Would you also directly do this in this PR? :)

[skjnldsv]

Shall I create a follow-up issue for this? But honestly it would be much better if that could be fixed directly in this PR...

It has already been discussed and ruled out :)
As said, it is not reasonably possible.

[skjnldsv]

Yes, would be really good to have that. Would you also directly do this in this PR? :)

No, this PR is too big, and I'm not doing a rebase danse :)
Followups are easier to reviewand faster to get in