[stable23] Appropriate length check in Notification.php#35116
Closed
backportbot-nextcloud[bot] wants to merge 1 commit intostable23from
Closed
[stable23] Appropriate length check in Notification.php#35116backportbot-nextcloud[bot] wants to merge 1 commit intostable23from
backportbot-nextcloud[bot] wants to merge 1 commit intostable23from
Conversation
There is an issue(bug) when using UTF-8 symbols in any method, which checks the length of string as `isset($id[64])`. You can set only 32 UTF-8 symbols because they are 2 byte, and this "array" check seems inapropriate in this case, as it throws unexpected exceptions. Signed-off-by: natoponen <57988162+natoponen@users.noreply.github.com>
szaimen
approved these changes
Nov 11, 2022
szaimen
requested review from
a team,
PVince81,
icewind1991 and
skjnldsv
and removed request for
a team
Member
|
This breaks on mysql without utf8mb4 support and is an unintended API change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #35015