Conversation
Contributor
|
First of all thanks for implementing this! :) I've tested this and a few remarks:
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
dcee700 to
742e96d
Compare
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
742e96d to
b7df419
Compare
Member
Author
|
Rebased and ready to review |
Contributor
|
I can give you an approval if the two points that I mentioned get added to #37627 😉 |
Member
Author
the second is already in this PR |
szaimen
approved these changes
Apr 11, 2023
Contributor
thanks! :) |
artonge
approved these changes
Apr 11, 2023
8 tasks
|
Does this change affect the "Rename" functionality as well? The focus after clicking "Rename" is out of sorts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement right click = actions menu open
Reference #37627 #36534