feat(dav): implement personal absence settings#40767
Merged
ChristophWurst merged 1 commit intomasterfrom Nov 8, 2023
Merged
Conversation
2 tasks
st3iny
force-pushed
the
feat/dav/absence
branch
from
1ef66bf to
2a1094f
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $this->initialState->provideInitialState('hide_absence', $hideAbsence); | ||
| if (!$hideAbsence) { | ||
| try { | ||
| $absence = $this->absenceMapper->findByUserId($this->userId); |
Check notice
Code scanning / Psalm
PossiblyNullArgument
st3iny
force-pushed
the
feat/dav/absence
branch
from
2a1094f to
3d08bb7
Compare
This was referenced Oct 23, 2023
st3iny
force-pushed
the
feat/dav/absence
branch
from
3d08bb7 to
c557c4a
Compare
st3iny
force-pushed
the
feat/dav/absence
branch
from
65b825d to
0956226
Compare
Merged
st3iny
force-pushed
the
feat/dav/absence
branch
from
0956226 to
e99916b
Compare
st3iny
added
3. to review
st3iny
force-pushed
the
feat/dav/absence
branch
from
e99916b to
0793e59
Compare
st3iny
force-pushed
the
feat/dav/absence
branch
from
0793e59 to
e17b0dd
Compare
ChristophWurst
approved these changes
Nov 2, 2023
Merged
st3iny
force-pushed
the
feat/dav/absence
branch
from
e17b0dd to
1248c5d
Compare
Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
force-pushed
the
feat/dav/absence
branch
from
1248c5d to
425e770
Compare
Member
Author
|
Rebase round 2 to finally get green CI 🙃 |
Member
|
Could this be moved into an OCS endpoint so talk mobile clients could set the OOO as well? |
Member
|
Good idea! #41458 |
| lastDay: formatDateAsYMD(this.lastDay), | ||
| status: this.status, | ||
| message: this.message, | ||
| }) |
Member
There was a problem hiding this comment.
Should show success after this?
| async clearAbsence() { | ||
| this.loading = true | ||
| try { | ||
| await axios.delete(generateUrl('/apps/dav/settings/absence')) |
Member
There was a problem hiding this comment.
Should show success after this?
4 tasks
Contributor
|
For translation, I'm not 100% sure of the strings
I tend to the first option, but in this case it would make sense to define the different kind of absence status like in other software (e.g. busy, away, available, ....) |
Member
|
The first one. the "Short" is set as "User status", the long one is shown in Mail and Talk close to the inputs iirc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The new absence form is hidden/disabled by default. It has to be manually enabled via the app config
hide_absence_settings.The help texts and descriptions might some need more work once the feature is fleshed out.
TODO
Checklist