fix(theming): Stop leaking user theme into capabilities#40877
fix(theming): Stop leaking user theme into capabilities#40877provokateurin wants to merge 1 commit intomasterfrom
Conversation
|
Might need some alignment between @nextcloud/designers and @tobiasKaminsky as those capabilities are used to style the clients. I would still expect the user colors in there |
|
I agree that the user theming should be exposed in the capabilities. I intend to implement that, but currently the capabilities expose a mix of user and admin theming. |
There was a problem hiding this comment.
I agree that the user theming should be exposed in the capabilities. I intend to implement that, but currently the capabilities expose a mix of user and admin theming.
If this will be done in a follow-up, I'd say this PR is fine from design perspective 👍
|
Right now I see no change for clients. |
|
@provokateurin Drone errors are related. |
|
Yes I know, I just didn't have the time yet :) |
a11a4f7 to
8a844c8
Compare
Signed-off-by: jld3103 <jld3103yt@gmail.com>
8a844c8 to
837eb45
Compare
|
I think the drone failure now is unrelated. Can someone confirm and possibly give it a force merge? |
|
Closed in favor of #41059 |
Summary
The capabilities were mixing the admin theme and the user theme. For now I set to only use the admin theming, but I intend to submit a second fix that uses the user theme if a the request came from a logged in user.
Checklist