Conversation
Merged
bd59ffc to
00d3856
Compare
e2691df to
2a12f0b
Compare
Keys for check results are not locale dependent anymore, the name of the setup check is instead stored in the setup result object. Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
2a12f0b to
86290dd
Compare
susnux
approved these changes
Nov 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The idea here is to avoid using the name as a key in the array as the name of setup checks is translated.
Before:
{ "dav": { "Checking for DAV system address book": { "severity": "success", "description": "No outstanding DAV system address book sync.", "linkToDoc": null } }, "security": { "Checking for old user imported certificate": { "severity": "success", "description": null, "linkToDoc": null }, "Code integrity": { "severity": "info", "description": "Integrity checker has been disabled. Integrity cannot be verified.", "linkToDoc": null },After:
{ "dav": { "OCA\\DAV\\SetupChecks\\NeedsSystemAddressBookSync": { "name": "Checking for DAV system address book", "severity": "success", "description": "No outstanding DAV system address book sync.", "linkToDoc": null } }, "security": { "OCA\\Settings\\SetupChecks\\CheckUserCertificates": { "name": "Checking for old user imported certificate", "severity": "success", "description": null, "linkToDoc": null }, "OCA\\Settings\\SetupChecks\\CodeIntegrity": { "name": "Code integrity", "severity": "info", "description": "Integrity checker has been disabled. Integrity cannot be verified.", "linkToDoc": null },Checklist